Messages in this thread | | | From | Miklos Szeredi <> | Subject | Re: [PATCH 2/6] fuse: categorize fuse_get_req() | Date | Wed, 12 Sep 2012 18:20:57 +0200 |
| |
Maxim Patlasov <mpatlasov@parallels.com> writes:
> The patch categorizes all fuse_get_req() invocations into three categories: > - fuse_get_req_nopages() - when caller doesn't care about req->pages > - fuse_get_req_onepage() - when caller need exactly one page > - fuse_get_req_multipage() - in other cases.
I think you are overcomplicating this.
Just have two functions: fuse_get_req_nopages() and fuse_get_req().
I don't think the _onepage variant deserves a separate helper.
Thanks, Miklos
| |