Messages in this thread | | | Date | Tue, 11 Sep 2012 16:08:31 +1000 | From | Ryan Mallon <> | Subject | Re: [PATCH] gpio: samsung: use pr_* instead of printk |
| |
On 10/09/12 21:59, Jingoo Han wrote: > This patch uses pr_* instead of printk. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- > drivers/gpio/gpio-samsung.c | 6 +++--- 1 files changed, 3 > insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-samsung.c > b/drivers/gpio/gpio-samsung.c index ba126cc..e38d990 100644 --- > a/drivers/gpio/gpio-samsung.c +++ b/drivers/gpio/gpio-samsung.c @@ > -45,7 +45,7 @@ #ifndef DEBUG_GPIO #define gpio_dbg(x...) do { } while > (0) #else -#define gpio_dbg(x...) printk(KERN_DEBUG x) +#define > gpio_dbg(x...) pr_debug(x)
This is a functional change since pr_debug compiles away to nothing unless DEBUG is defined, so now you need to define both DEBUG and DEBUG_GPIO for this to print.
A better fix would be to just replace calls to gpio_dbg with pr_debug.
~Ryan
| |