Messages in this thread | | | From | Chris Ball <> | Subject | Re: [PATCH 09/16] ARM: tegra: move platform_data definitions | Date | Tue, 11 Sep 2012 13:11:55 -0400 |
| |
Hi,
On Tue, Sep 11 2012, Arnd Bergmann wrote: >> Looks like you aren't renaming the idempotency guards, so e.g. >> include/linux/platform_data/mmc-sdhci-tegra.h will contain: >> >> #ifndef __ASM_ARM_ARCH_TEGRA_SDHCI_H >> #define __ASM_ARM_ARCH_TEGRA_SDHCI_H >> >> Is that intentional? Thanks, > > No, it's not intentional. We actually have a lot of instances that > are already wrong. Do we care enough to change the ones I'm moving here?
It's clearly not a big deal. I did fix it in Stephen's previous version of this change, though.
Maybe just add a note to the commit message explaining that you aren't changing the guards and driver maintainers might want to fix them up if it's something they care about?
Thanks,
- Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child
| |