Messages in this thread | | | Date | Tue, 11 Sep 2012 00:24:49 +0100 | From | Alan Cox <> | Subject | Re: [char-misc-next 2/3] mei: struct mei_message_data doesn't have to be packed |
| |
On Tue, 11 Sep 2012 00:43:21 +0300 Tomas Winkler <tomas.winkler@intel.com> wrote:
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > --- > drivers/misc/mei/mei_dev.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/misc/mei/mei_dev.h b/drivers/misc/mei/mei_dev.h > index 96d3e79..adb35fb 100644 > --- a/drivers/misc/mei/mei_dev.h > +++ b/drivers/misc/mei/mei_dev.h > @@ -140,7 +140,7 @@ enum mei_cb_major_types { > struct mei_message_data { > u32 size; > unsigned char *data; > -} __packed; > +};
Explanation would be useful especially for this one. The others are obvious although a one line comment would still be good form perhaps.
| |