lkml.org 
[lkml]   [2012]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC] DMA mapping error check analysis
    From
    Date

    > >
    > > http://linuxdriverproject.org/mediawiki/index.php/DMA_Mapping_Error_Analysis
    >
    > > File Name # of calls Status
    > > drivers/firewire/core-iso.c 1 Unmap Broken
    > > drivers/firewire/ohci.c 1 Unmap Broken
    >
    > In ohci.c, ar_context_release() takes care of cleanup.
    >
    > In core-iso.c, on failure, the callers are responsible to call
    > fw_iso_buffer_destroy() eventually. (ioctl_create_iso_context()
    > doesn't do this correctly if it's called multiple times.)
    >

    Thanks. I updated the page with your comments. I moved ohci.c to Good
    status and left core-iso.c in Unmap Broken in case
    ioctl_create_iso_context() case is worth fixing.

    -- Shuah



    \
     
     \ /
      Last update: 2012-09-10 18:02    [W:0.026 / U:0.644 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site