lkml.org 
[lkml]   [2012]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 16/19] mfd: Provide the tc3589x with its own IRQ domain
    From
    On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@linaro.org> wrote:

    > In preparation for Device Tree enablement all IRQ controllers
    > should control their own IRQ domain. This patch provides just
    > that.
    >
    > CC: Samuel Ortiz <sameo@linux.intel.com>
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    It's always nice to have irqdomains added, excellent patch!

    > + if (base) {
    > + tc3589x->domain = irq_domain_add_legacy(
    > + NULL, TC3589x_NR_INTERNAL_IRQS, base,
    > + 0, &tc3589x_irq_ops, tc3589x);
    > }
    > + else {
    > + tc3589x->domain = irq_domain_add_linear(
    > + NULL, TC3589x_NR_INTERNAL_IRQS,
    > + &tc3589x_irq_ops, tc3589x);
    > + }

    This is especially elegant, well done.
    Not my subsystem, but FWIW:
    Acked-by: Linus Walleij <linus.walleij@linaro.org>

    Yours,
    Linus Walleij


    \
     
     \ /
      Last update: 2012-09-10 15:41    [W:0.047 / U:121.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site