lkml.org 
[lkml]   [2012]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH][v3] sata_fsl: add workaround for data length mismatch on freescale V2 controller
Date
> -----Original Message-----
> From: Sergei Shtylyov [mailto:sshtylyov@mvista.com]
> Sent: Monday, September 10, 2012 6:22 PM
> To: Xie Shaohui-B21989
> Cc: Kumar Gala; jgarzik@pobox.com; linux-ide@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Bhartiya Anju-B07263
> Subject: Re: [PATCH][v3] sata_fsl: add workaround for data length
> mismatch on freescale V2 controller
>
> Hello.
>
> On 10-09-2012 6:53, Xie Shaohui-B21989 wrote:
>
> >>> + /* Workaround for data length mismatch errata */
> >>> + if (unlikely(hstatus & INT_ON_DATA_LENGTH_MISMATCH)) {
> >>> + for (tag = 0; tag < ATA_MAX_QUEUE; tag++) {
> >>> + qc = ata_qc_from_tag(ap, tag);
> >>> + if (qc && ata_is_atapi(qc->tf.protocol)) {
> >>> + u32 hcontrol;
> >>> +#define HCONTROL_CLEAR_ERROR (1 << 27)
>
> >> shouldn't we have this #define be part of the enum that the other
> >> HCONTROL_ bits/flags are part of?
>
> > [S.H] do you mean this?
>
> Apparently not. He said *enum*, not #define.

[S.H] OK. Thank you for the clarification.


Best Regards,
Shaohui Xie



\
 
 \ /
  Last update: 2012-09-10 13:21    [from the cache]
©2003-2011 Jasper Spaans