Messages in this thread |  | | | Date | Sat, 1 Sep 2012 16:44:29 +0530 | | Subject | Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO | | From | shiraz hashim <> |
| |
Hi Roland,
On Wed, Aug 22, 2012 at 7:19 PM, Roland Stigge <stigge@antcom.de> wrote: > @@ -2016,6 +2030,8 @@ pl022_probe(struct amba_device *adev, co > pl022->master_info = platform_info; > pl022->adev = adev; > pl022->vendor = id->data; > + /* Point chipselects to allocated memory beyond the main struct */ > + pl022->chipselects = (int *) pl022 + sizeof(struct pl022);
This is going beyond memory allocated for chipselects as it adds 4 * sizeof(struct pl022) bytes to pl022.
pl022->chipselects = (int *) &pl022[1]; can be musch safer.
-- regards Shiraz Hashim
|  |