Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH 02/19] mm/mpol: Remove NUMA_INTERLEAVE_HIT | Date | Thu, 09 Aug 2012 17:50:55 -0700 |
| |
Andrea Arcangeli <aarcange@redhat.com> writes:
> Hi, > > On Tue, Jul 31, 2012 at 09:12:06PM +0200, Peter Zijlstra wrote: >> Since the NUMA_INTERLEAVE_HIT statistic is useless on its own; it wants >> to be compared to either a total of interleave allocations or to a miss >> count, remove it. >> >> Fixing it would be possible, but since we've gone years without these >> statistics I figure we can continue that way. >> >> Also NUMA_HIT fully includes NUMA_INTERLEAVE_HIT so users might >> switch to using that. >> >> This cleans up some of the weird MPOL_INTERLEAVE allocation exceptions. > > It's not apparent why you need to remove it for sched-numa. I think I > see it but it'd be nicer if it would explained so one doesn't need to > read an internal bit of several patches later to understand why this > is needed.
Also it still breaks the numactl test suite, as already explained multiple times. Without the HIT counter there is no way to check interleave actually happened.
I'm a bit concerned about patch kits like this ignoring review feedback?
-Andi
-- ak@linux.intel.com -- Speaking for myself only
| |