lkml.org 
[lkml]   [2012]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] tun: don't zeroize sock->file on detach
    From
    From: Stanislav Kinsbursky <skinsbursky@parallels.com>
    Date: Thu, 09 Aug 2012 16:50:40 +0400

    > This is a fix for bug, introduced in 3.4 kernel by commit
    > 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced
    > simple sock_put() by sk_release_kernel(). Below is sequence, which leads to
    > oops for non-persistent devices:
    >
    > tun_chr_close()
    > tun_detach() <== tun->socket.file = NULL
    > tun_free_netdev()
    > sk_release_sock()
    > sock_release(sock->file == NULL)
    > iput(SOCK_INODE(sock)) <== dereference on NULL pointer
    >
    > This patch just removes zeroing of socket's file from __tun_detach().
    > sock_release() will do this.
    >
    > Cc: stable@vger.kernel.org
    > Reported-by: Ruan Zhijie <ruanzhijie@hotmail.com>
    > Tested-by: Ruan Zhijie <ruanzhijie@hotmail.com>
    > Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
    > Acked-by: Eric Dumazet <edumazet@google.com>
    > Acked-by: Yuchung Cheng <ycheng@google.com>
    > Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>

    Applied, thanks.


    \
     
     \ /
      Last update: 2012-08-10 02:01    [W:0.027 / U:94.480 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site