lkml.org 
[lkml]   [2012]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] mm: Restructure kmem_cache_create() to move debug cache integrity checks into a new function
    On Mon, 6 Aug 2012, Shuah Khan wrote:

    > +#ifdef CONFIG_DEBUG_VM
    > +static int kmem_cache_sanity_check(const char *name, size_t size)

    Why do we pass "size" in? AFAICT there is no need to.

    > @@ -53,48 +93,17 @@ struct kmem_cache *kmem_cache_create(const char *name, size_t size, size_t align
    > {
    > struct kmem_cache *s = NULL;
    >
    > -#ifdef CONFIG_DEBUG_VM
    > if (!name || in_interrupt() || size < sizeof(void *) ||
    > size > KMALLOC_MAX_SIZE) {
    > - printk(KERN_ERR "kmem_cache_create(%s) integrity check"
    > - " failed\n", name);
    > + pr_err("kmem_cache_create(%s) integrity check failed\n", name);
    > goto out;
    > }
    > -#endif
    >

    If you move the above code into the sanity check function then you will be
    using the size as well. These are also sanity checks after all.


    \
     
     \ /
      Last update: 2012-08-09 17:02    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean