lkml.org 
[lkml]   [2012]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/5] mm: compaction: Update comment in try_to_compact_pages
    Date
    The comment about order applied when the check was
    order > PAGE_ALLOC_COSTLY_ORDER which has not been the case since
    [c5a73c3d: thp: use compaction for all allocation orders]. Fixing
    the comment while I'm in the general area.

    Signed-off-by: Mel Gorman <mgorman@suse.de>
    Reviewed-by: Rik van Riel <riel@redhat.com>
    Reviewed-by: Minchan Kim <minchan@kernel.org>
    ---
    mm/compaction.c | 6 +-----
    1 file changed, 1 insertion(+), 5 deletions(-)

    diff --git a/mm/compaction.c b/mm/compaction.c
    index b39ede1..95ca967 100644
    --- a/mm/compaction.c
    +++ b/mm/compaction.c
    @@ -759,11 +759,7 @@ unsigned long try_to_compact_pages(struct zonelist *zonelist,
    struct zone *zone;
    int rc = COMPACT_SKIPPED;

    - /*
    - * Check whether it is worth even starting compaction. The order check is
    - * made because an assumption is made that the page allocator can satisfy
    - * the "cheaper" orders without taking special steps
    - */
    + /* Check if the GFP flags allow compaction */
    if (!order || !may_enter_fs || !may_perform_io)
    return rc;

    --
    1.7.9.2


    \
     
     \ /
      Last update: 2012-08-09 16:42    [W:0.021 / U:130.184 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site