lkml.org 
[lkml]   [2012]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [GIT PULL for 3.6-rc1] media updates part 2
    Hi,

    My bad, sorry about this. Mauro's patch looks good. An alternative fix
    would be to #ifdefify the led code in the drivers themselves.

    Regards,

    Hans


    On 08/09/2012 01:38 PM, Mauro Carvalho Chehab wrote:
    > Em 08-08-2012 19:28, David Rientjes escreveu:
    >> On Tue, 31 Jul 2012, Mauro Carvalho Chehab wrote:
    >>
    >>> [media] radio-shark: New driver for the Griffin radioSHARK USB radio receiver
    >>
    >> This one gives me a build warning if CONFIG_LEDS_CLASS is disabled:
    >>
    >> ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
    >> ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!
    >>
    >
    > Could you please test the enclosed patch?
    >
    > Thanks!
    > Mauro
    >
    > -
    >
    > [media] radio-shark: make sure LEDS_CLASS is selected
    >
    > As reported by David:
    > > ERROR: "led_classdev_register" [drivers/media/radio/shark2.ko] undefined!
    > > ERROR: "led_classdev_unregister" [drivers/media/radio/shark2.ko] undefined!
    >
    > Reported-by: Dadiv Rientjes <rientjes@google.com>
    > Cc: Hans de Goede <hdegoede@redhat.com>
    > Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    >
    >
    > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
    > index 8090b87..be68ec2 100644
    > --- a/drivers/media/radio/Kconfig
    > +++ b/drivers/media/radio/Kconfig
    > @@ -60,6 +60,7 @@ config RADIO_MAXIRADIO
    > config RADIO_SHARK
    > tristate "Griffin radioSHARK USB radio receiver"
    > depends on USB && SND
    > + select LEDS_CLASS
    > ---help---
    > Choose Y here if you have this radio receiver.
    >
    > @@ -77,6 +78,7 @@ config RADIO_SHARK
    > config RADIO_SHARK2
    > tristate "Griffin radioSHARK2 USB radio receiver"
    > depends on USB
    > + select LEDS_CLASS
    > ---help---
    > Choose Y here if you have this radio receiver.
    >
    >


    \
     
     \ /
      Last update: 2012-08-09 14:41    [W:0.036 / U:0.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site