lkml.org 
[lkml]   [2012]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2] usb: gadget: composite: parse dt values
    From
    On Thu, Aug 9, 2012 at 8:49 AM, Felipe Balbi <balbi@ti.com> wrote:
    > Hi,
    >
    > On Thu, Aug 09, 2012 at 01:42:42PM +0200, Sebastian Andrzej Siewior wrote:
    >> On Tue, Jul 24, 2012 at 10:15:20AM -0300, Alexandre Pereira da Silva wrote:
    >> > --- /dev/null
    >> > +++ b/Documentation/devicetree/bindings/usb/gadget.txt
    >> > @@ -0,0 +1,20 @@
    >> > +Usb Gadget DeviceTree bindings
    >> > +
    >> > +These optional properties inside the usb device controller node are used to
    >> > +change some of the gadget drivers configuration:
    >> > +- vendor-id: Usb vendor id
    >> > +- product-id: Usb product id
    >> > +- release: Version of this device
    >> > +- vendor: Textual description of the vendor
    >> > +- device: Textual description of this device
    >> > +- serial: Textual representation of the device's serial number
    >> > +
    >> > +Binding Example:
    >> > + usbd@31020000 {
    >> > + vendor-id = <0x0525>;
    >> > + product-id = <0xa4a6>;
    >> > + release = <1>;
    >> > + vendor = "Some Corp";
    >> > + device = "Test Device";
    >> > + serial = "12345";
    >
    > on top of everything Sebastian said, I think we should stick to the
    > field names set forth on the USB specification meaning that instead of
    > vendor-id we should use idVendor, instead of vendor we should use
    > iManufacturer, and so on.

    Thanks for the feedback.

    I agree that this should look more like the usb specifications and
    allow mapping between usb interfaces and gadget drivers.

    I will rework this to provide a new patch that at least don't conflict
    with this idea.


    \
     
     \ /
      Last update: 2012-08-09 14:23    [W:0.022 / U:30.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site