lkml.org 
[lkml]   [2012]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mmc: sdio: Fix PM_SLEEP related build warnings
    On Thu, Aug 09, 2012 at 11:27:02AM +0200, Rafael J. Wysocki wrote:
    > On Thursday, August 09, 2012, Thierry Reding wrote:
    > > Power management callbacks defined by SIMPLE_DEV_PM_OPS are only used if
    > > the PM_SLEEP Kconfig symbol has been defined. If not, the compiler will
    > > complain about them being unused.
    > >
    > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
    >
    > The pm_no_operation() thing is not necessary at all, AFAICT. I'd just
    > remove it entirely. :-)

    I don't actually have a setup where I can test suspend/resume with this
    driver, but if you say so I can follow up with a patch that removes
    pm_no_operation(). It should work because many drivers without proper
    PM_SLEEP support do not specify .suspend() nor .resume() callbacks
    either.

    Thierry
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-08-09 12:21    [W:0.022 / U:90.900 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site