[lkml]   [2012]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [dm-devel] [PATCH v2 1/2] dm: verity support data device offset (Linux 3.4.7)
On Thu, Aug 09, 2012 at 12:40:22AM +0000, Wesley Miaw wrote:
> Apologies if the version increment is incorrect; I was not sure if the minor
> or patch number should be incremented. I assume the different version number is
> what would be used to detect if the data offset option is supported. Thanks.

Minor number is the correct thing to increment as you're retaining
compatibility. (Your original version would have needed to increment the major
number to indicate incompatibility with existing userspace code.)

However, first you need to address the second part of Mikulas's email,
namely to make the case for these changes rather than making no kernel
changes and instead stacking the verity target over a linear target.

To put this another way, your patch offers an alternative way to do
something we think the existing kernel can already do, so you need to
advance some reasons why you believe the new alternative method is worth
adding to the kernel and explain this in the patch header.


 \ /
  Last update: 2012-08-09 04:42    [W:0.071 / U:2.872 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site