lkml.org 
[lkml]   [2012]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 07/11] net/stmmac: mark probe function as __devinit
    From
    From: Arnd Bergmann <arnd@arndb.de>
    Date: Wed, 8 Aug 2012 16:47:24 +0200

    > Driver probe functions are generally __devinit so they will be
    > discarded after initialization for non-hotplug kernels.
    > This was found by a new warning after patch 6a228452d "stmmac: Add
    > device-tree support" adds a new __devinit function that is called
    > from stmmac_pltfr_probe.
    >
    > Without this patch, building socfpga_defconfig results in:
    >
    > WARNING: drivers/net/ethernet/stmicro/stmmac/stmmac.o(.text+0x5d4c): Section mismatch in reference from the function stmmac_pltfr_probe() to the function .devinit.text:stmmac_probe_config_dt()
    > The function stmmac_pltfr_probe() references
    > the function __devinit stmmac_probe_config_dt().
    > This is often because stmmac_pltfr_probe lacks a __devinit
    > annotation or the annotation of stmmac_probe_config_dt is wrong.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > Cc: Stefan Roese <sr@denx.de>
    > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
    > Cc: David S. Miller <davem@davemloft.net>
    > Cc: netdev@vger.kernel.org

    Applied, thanks.


    \
     
     \ /
      Last update: 2012-08-09 01:41    [W:0.042 / U:1.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site