lkml.org 
[lkml]   [2012]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 01/12] block: Generalized bio pool freeing
    On Mon, Aug 06, 2012 at 03:08:30PM -0700, Kent Overstreet wrote:
    > @@ -422,7 +409,11 @@ void bio_put(struct bio *bio)
    > if (atomic_dec_and_test(&bio->bi_cnt)) {
    > bio_disassociate_task(bio);
    > bio->bi_next = NULL;
    > - bio->bi_destructor(bio);
    > +
    > + if (bio->bi_pool)
    > + bio_free(bio, bio->bi_pool);
    > + else
    > + bio->bi_destructor(bio);

    So, this bi_pool overriding caller specified custom bi_destructor is
    rather unusual. I know why it's like that - the patch series is
    gradually replacing bi_destructor with bi_pool and removes
    bi_destructor eventually, but it would be far better if at least patch
    description says why this is unusual like this.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2012-08-09 01:01    [W:0.023 / U:60.588 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site