lkml.org 
[lkml]   [2012]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/10] ARM: davinci: don't use broken ntosd2_init_i2c
    Date
    ntosd2_init_i2c walks the ntosd2_i2c_info array, which it expects to
    be populated with at least one member. gcc correctly warns about
    the out-of-bounds access here.

    Without this patch, building davinci_all_defconfig results in:

    arch/arm/mach-davinci/board-neuros-osd2.c: In function 'davinci_ntosd2_init':
    arch/arm/mach-davinci/board-neuros-osd2.c:187:20: warning: array subscript is above array bounds [-Warray-bounds]

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Cc: Kevin Hilman <khilman@ti.com>
    Cc: Sekhar Nori <nsekhar@ti.com>
    Cc: Andrey Porodko <panda@chelcom.ru>
    ---
    arch/arm/mach-davinci/board-neuros-osd2.c | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/arch/arm/mach-davinci/board-neuros-osd2.c b/arch/arm/mach-davinci/board-neuros-osd2.c
    index 5de69f2..9d40df9 100644
    --- a/arch/arm/mach-davinci/board-neuros-osd2.c
    +++ b/arch/arm/mach-davinci/board-neuros-osd2.c
    @@ -162,6 +162,7 @@ static void __init davinci_ntosd2_map_io(void)
    dm644x_init();
    }

    +#if 0
    /*
    I2C initialization
    */
    @@ -193,6 +194,12 @@ static int ntosd2_init_i2c(void)
    }
    return status;
    }
    +#else
    +static int ntosd2_init_i2c(void)
    +{
    + return 0;
    +}
    +#endif

    static struct davinci_mmc_config davinci_ntosd2_mmc_config = {
    .wires = 4,
    --
    1.7.10


    \
     
     \ /
      Last update: 2012-08-09 00:01    [W:0.025 / U:30.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site