lkml.org 
[lkml]   [2012]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RESEND #2 2/3] tty: fix missing assignment
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    We're trying to save the termios state and we need to allocate a buffer
    to do it. Smatch complains that the buffer is leaked at the end of the
    function.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Alan Cox <alan@linux.intel.com>
    ---

    drivers/tty/tty_io.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
    index c6f4d71..6087499 100644
    --- a/drivers/tty/tty_io.c
    +++ b/drivers/tty/tty_io.c
    @@ -1450,6 +1450,7 @@ void tty_free_termios(struct tty_struct *tty)
    pr_warn("tty: no memory to save termios state.\n");
    return;
    }
    + tty->driver->termios[idx] = tp;
    }
    *tp = tty->termios;
    }


    \
     
     \ /
      Last update: 2012-08-08 18:01    [W:0.023 / U:0.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site