| Date | Wed, 08 Aug 2012 15:17:52 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH 2/5] x86/uprobes: implement x86 specific arch_uprobe_*_step |
| |
On 08/08/2012 02:57 PM, Oleg Nesterov wrote: >> +static int insn_changes_flags(struct arch_uprobe *auprobe) >> +{ >> + /* popf reads flags from stack */ >> + if (auprobe->insn[0] == 0x9d) >> + return 1; > > Ah, somehow I didn't think about this before. > > ->insn[0] doesn't look right, we should skip the prefixes.
Why? I tried 'lock popf' and I got invalid instruction. The same for 'rep popf'.
> Oleg. >
Sebastian
|