Messages in this thread | | | Date | Wed, 8 Aug 2012 12:40:38 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between DT and non-DT boots |
| |
On Wed, Aug 08, 2012 at 10:49:52AM +0100, Mark Brown wrote: > On Wed, Aug 08, 2012 at 09:04:12AM +0100, Lee Jones wrote: > > > During non-DT boot: > > - Platform data is passed, which contains an IRQ base > > - If an IRQ base is requested we use it to register a Legacy IRQ Domain > > - MFD adds the IRQ base to the hwirq and registers it as a virq > > Just don't do this step - the only reason to do it is for mapping back > into a linear domain but if you're going to do this... > > > - AB8500 child devices use *_get_virq() to convert virq to virq - *ERROR* > > ...then it's redundant. The mapping functions in the domain code > replace this functionality.
No, the other way round. This is now required all the time.
Now we force the use of hwirq, the driver needs to convert that into a virq before requesting the resource. So we need to put *_get_virq()'s into every child device that requests an IRQ.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |