lkml.org 
[lkml]   [2012]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 096/109] ALSA: snd-usb: fix clock source validity index
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.4-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Daniel Mack <zonque@gmail.com>

    commit aff252a848ce21b431ba822de3dab9c4c94571cb upstream.

    uac_clock_source_is_valid() uses the control selector value to access
    the bmControls bitmap of the clock source unit. This is wrong, as
    control selector values start from 1, while the bitmap uses all
    available bits.

    In other words, "Clock Validity Control" is stored in D3..2, not D5..4
    of the clock selector unit's bmControls.

    Signed-off-by: Daniel Mack <zonque@gmail.com>
    Reported-by: Andreas Koch <andreas@akdesigninc.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/usb/clock.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/sound/usb/clock.c
    +++ b/sound/usb/clock.c
    @@ -111,7 +111,8 @@ static bool uac_clock_source_is_valid(st
    return 0;

    /* If a clock source can't tell us whether it's valid, we assume it is */
    - if (!uac2_control_is_readable(cs_desc->bmControls, UAC2_CS_CONTROL_CLOCK_VALID))
    + if (!uac2_control_is_readable(cs_desc->bmControls,
    + UAC2_CS_CONTROL_CLOCK_VALID - 1))
    return 1;

    err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), UAC2_CS_CUR,



    \
     
     \ /
      Last update: 2012-08-08 02:01    [W:0.023 / U:31.308 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site