lkml.org 
[lkml]   [2012]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 018/109] ASoC: dapm: Fix _PRE and _POST events for DAPM performance improvements
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.4-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Mark Brown <broonie@opensource.wolfsonmicro.com>

    commit 0ff97ebf0804d2e519d578fcb4db03f104d2ca8c upstream.

    Ever since the DAPM performance improvements we've been marking all widgets
    as not dirty after each DAPM run. Since _PRE and _POST events aren't part
    of the DAPM graph this has rendered them non-functional, they will never be
    marked dirty again and thus will never be run again.

    Fix this by skipping them when marking widgets as not dirty.

    Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
    Acked-by: Liam Girdwood <lrg@ti.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/soc/soc-dapm.c | 10 +++++++++-
    1 file changed, 9 insertions(+), 1 deletion(-)

    --- a/sound/soc/soc-dapm.c
    +++ b/sound/soc/soc-dapm.c
    @@ -1442,7 +1442,15 @@ static int dapm_power_widgets(struct snd
    }

    list_for_each_entry(w, &card->widgets, list) {
    - list_del_init(&w->dirty);
    + switch (w->id) {
    + case snd_soc_dapm_pre:
    + case snd_soc_dapm_post:
    + /* These widgets always need to be powered */
    + break;
    + default:
    + list_del_init(&w->dirty);
    + break;
    + }

    if (w->power) {
    d = w->dapm;



    \
     
     \ /
      Last update: 2012-08-08 02:01    [W:4.408 / U:0.584 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site