lkml.org 
[lkml]   [2012]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 009/109] SCSI: libsas: continue revalidation
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.4-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Dan Williams <dan.j.williams@intel.com>

    commit 26f2f199ff150d8876b2641c41e60d1c92d2fb81 upstream.

    Continue running revalidation until no more broadcast devices are
    discovered. Fixes cases where re-discovery completes too early in a
    domain with multiple expanders with pending re-discovery events.
    Servicing BCNs can get backed up behind error recovery.

    Signed-off-by: Dan Williams <dan.j.williams@intel.com>
    Signed-off-by: James Bottomley <JBottomley@Parallels.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/libsas/sas_expander.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    --- a/drivers/scsi/libsas/sas_expander.c
    +++ b/drivers/scsi/libsas/sas_expander.c
    @@ -2109,9 +2109,7 @@ int sas_ex_revalidate_domain(struct doma
    struct domain_device *dev = NULL;

    res = sas_find_bcast_dev(port_dev, &dev);
    - if (res)
    - goto out;
    - if (dev) {
    + while (res == 0 && dev) {
    struct expander_device *ex = &dev->ex_dev;
    int i = 0, phy_id;

    @@ -2123,8 +2121,10 @@ int sas_ex_revalidate_domain(struct doma
    res = sas_rediscover(dev, phy_id);
    i = phy_id + 1;
    } while (i < ex->num_phys);
    +
    + dev = NULL;
    + res = sas_find_bcast_dev(port_dev, &dev);
    }
    -out:
    return res;
    }




    \
     
     \ /
      Last update: 2012-08-08 02:01    [W:4.377 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site