lkml.org 
[lkml]   [2012]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 079/122] drm/radeon: Try harder to avoid HW cursor ending on a multiple of 128 columns.
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.5-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Michel Dänzer <michel.daenzer@amd.com>

    commit f60ec4c7df043df81e62891ac45383d012afe0da upstream.

    This could previously fail if either of the enabled displays was using a
    horizontal resolution that is a multiple of 128, and only the leftmost column
    of the cursor was (supposed to be) visible at the right edge of that display.

    The solution is to move the cursor one pixel to the left in that case.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=33183

    Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/radeon/radeon_cursor.c | 8 +++++++-
    1 file changed, 7 insertions(+), 1 deletion(-)

    --- a/drivers/gpu/drm/radeon/radeon_cursor.c
    +++ b/drivers/gpu/drm/radeon/radeon_cursor.c
    @@ -262,8 +262,14 @@ int radeon_crtc_cursor_move(struct drm_c
    if (!(cursor_end & 0x7f))
    w--;
    }
    - if (w <= 0)
    + if (w <= 0) {
    w = 1;
    + cursor_end = x - xorigin + w;
    + if (!(cursor_end & 0x7f)) {
    + x--;
    + WARN_ON_ONCE(x < 0);
    + }
    + }
    }
    }


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-08-08 01:21    [W:0.029 / U:121.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site