lkml.org 
[lkml]   [2012]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v0 02/12] x86, microcode: Save an indentation level in reload_for_cpu
    Date
    From: Borislav Petkov <borislav.petkov@amd.com>

    Invert the uci->valid check so that the later block can be aligned on
    the first indentation level of the function. No functional change.

    Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
    ---
    arch/x86/kernel/microcode_core.c | 19 +++++++++----------
    1 file changed, 9 insertions(+), 10 deletions(-)

    diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c
    index 4873e62db6a1..63a956865022 100644
    --- a/arch/x86/kernel/microcode_core.c
    +++ b/arch/x86/kernel/microcode_core.c
    @@ -276,19 +276,18 @@ static struct platform_device *microcode_pdev;
    static int reload_for_cpu(int cpu)
    {
    struct ucode_cpu_info *uci = ucode_cpu_info + cpu;
    + enum ucode_state ustate;
    int err = 0;

    - if (uci->valid) {
    - enum ucode_state ustate;
    -
    - ustate = microcode_ops->request_microcode_fw(cpu, &microcode_pdev->dev);
    - if (ustate == UCODE_OK)
    - apply_microcode_on_target(cpu);
    - else
    - if (ustate == UCODE_ERROR)
    - err = -EINVAL;
    - }
    + if (!uci->valid)
    + return err;

    + ustate = microcode_ops->request_microcode_fw(cpu, &microcode_pdev->dev);
    + if (ustate == UCODE_OK)
    + apply_microcode_on_target(cpu);
    + else
    + if (ustate == UCODE_ERROR)
    + err = -EINVAL;
    return err;
    }

    --
    1.7.11.rc1


    \
     
     \ /
      Last update: 2012-08-07 20:21    [W:5.042 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site