lkml.org 
[lkml]   [2012]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net:appletalk:ddp:fixed coding style issue again relating to
From
Date
On Tue, 2012-08-07 at 20:27 +0530, Jeffrin Jose wrote:
> / Is putting "rc = put_user(amount, (int __user *)argp);" on the same
> / indentation level as "amount = skb->len - sizeof(struct ddpehdr);"
> / really what you want to do?

> No. I was trying to place those lines at one
> indentation back from their current position.

If you are using checkpatch as a guide, run
"./scripts/checkpatch.pl -f --strict net/appletalk/ddp.c"
after you patch it and also correct any problems found in
the area you want to update too.

A second option is to use emacs with the proper linux
style indentation.

(See: Documentation/CodingStyle, Chapter 9: You've made a mess of it)

Another option is not to patch the file at all.

Also, don't submit multiple patches, resubmit 1 single patch
with all the appropriate corrections.




\
 
 \ /
  Last update: 2012-08-07 18:42    [W:0.035 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site