lkml.org 
[lkml]   [2012]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/6] cpupower tools: Fix minor warnings
    Date
    Fix minor warnings reported with GCC 4.6:
    * The sysfs_write_file function is unused - remove it.
    * The pr_mon_len in the print_header function is unsed - remove it.
    ---
    tools/power/cpupower/utils/helpers/sysfs.c | 19 -------------------
    .../cpupower/utils/idle_monitor/cpupower-monitor.c | 3 +--
    2 files changed, 1 insertion(+), 21 deletions(-)

    diff --git a/tools/power/cpupower/utils/helpers/sysfs.c b/tools/power/cpupower/utils/helpers/sysfs.c
    index 96e28c1..38ab916 100644
    --- a/tools/power/cpupower/utils/helpers/sysfs.c
    +++ b/tools/power/cpupower/utils/helpers/sysfs.c
    @@ -37,25 +37,6 @@ unsigned int sysfs_read_file(const char *path, char *buf, size_t buflen)
    return (unsigned int) numread;
    }

    -static unsigned int sysfs_write_file(const char *path,
    - const char *value, size_t len)
    -{
    - int fd;
    - ssize_t numwrite;
    -
    - fd = open(path, O_WRONLY);
    - if (fd == -1)
    - return 0;
    -
    - numwrite = write(fd, value, len);
    - if (numwrite < 1) {
    - close(fd);
    - return 0;
    - }
    - close(fd);
    - return (unsigned int) numwrite;
    -}
    -
    /*
    * Detect whether a CPU is online
    *
    diff --git a/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c b/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c
    index 0d6571e..7a657f3 100644
    --- a/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c
    +++ b/tools/power/cpupower/utils/idle_monitor/cpupower-monitor.c
    @@ -84,7 +84,7 @@ int fill_string_with_spaces(char *s, int n)
    void print_header(int topology_depth)
    {
    int unsigned mon;
    - int state, need_len, pr_mon_len;
    + int state, need_len;
    cstate_t s;
    char buf[128] = "";
    int percent_width = 4;
    @@ -93,7 +93,6 @@ void print_header(int topology_depth)
    printf("%s|", buf);

    for (mon = 0; mon < avail_monitors; mon++) {
    - pr_mon_len = 0;
    need_len = monitors[mon]->hw_states_num * (percent_width + 3)
    - 1;
    if (mon != 0) {
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2012-08-07 05:01    [W:0.036 / U:160.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site