lkml.org 
[lkml]   [2012]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] video: s3c-fb: Fix compile error/warning if CONFIG_OF is not selected
    Date
    On Monday, August 06, 2012 10:58 PM Dongjin Kim wrote:
    >
    > Change-Id: I5d7ff6f0070a10225d5b064b362d3d8f214787fd
    > Signed-off-by: Dongjin Kim <dongjin.kim@agreeyamobility.net>
    > ---
    > drivers/video/s3c-fb.c | 6 ++----
    > 1 file changed, 2 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
    > index 8c8adb5..268be0c 100644
    > --- a/drivers/video/s3c-fb.c
    > +++ b/drivers/video/s3c-fb.c
    > @@ -1527,13 +1527,11 @@ static int s3c_fb_dt_parse_gpios(struct device *dev, struct s3c_fb *sfb,
    >
    > static void s3c_fb_dt_free_gpios(struct s3c_fb *sfb)
    > {
    > - return 0;
    > }
    >
    > -static int s3c_fb_dt_parse_pdata(struct device *dev,
    > - struct s3c_fb_platdata **pdata)
    > +static struct s3c_fb_platdata *s3c_fb_dt_parse_pdata(struct device *dev)
    > {
    > - return 0;
    > + return NULL;
    > }
    > #endif /* CONFIG_OF */


    Um, DT is not yet merged to s3c-fb driver.
    s3c_fb_dt_parse_pdata() and s3c_fb_dt_free_gpios() are not available.

    So, this patch is unnecessary.

    Best regards,
    Jingoo Han


    >
    > --
    > 1.7.9.5



    \
     
     \ /
      Last update: 2012-08-07 03:01    [W:2.556 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site