lkml.org 
[lkml]   [2012]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/3] perf: teach perf inject to merge sched_stat_* and sched_switch events
From
Hello Arnaldo,

Thanks for comments, I will correct them. I need a bit more details
about two of them.

2012/8/6 Arnaldo Carvalho de Melo <acme@ghostprotocols.net>:
>> @@ -21,6 +23,9 @@ static int output;
>> static u64 bytes_written;
>>
>> static bool inject_build_ids;
>> +static bool inject_sched_stat;
>> +
>> +struct perf_session *session;

perf_event__sched_stat (perf_inject.sample) uses "session" for getting
an event name. I don't know how to get it by another way

>
> Why do we need to insert even more globals?
>
>> static int perf_event__repipe_synth(struct perf_tool *tool __used,
>> union perf_event *event,
>> @@ -47,7 +52,7 @@ static int perf_event__repipe_synth(struct perf_tool *tool __used,
>>
>> static int perf_event__repipe_op2_synth(struct perf_tool *tool,
>> union perf_event *event,
>> - struct perf_session *session __used)
>> + struct perf_session *s __used)
>
> What is the point of the above hunk?

"session" is global, for this reason I renamed all arguments.

p.s. Arnaldo, sorry for the personal message with the same content.
It's my mistake.


\
 
 \ /
  Last update: 2012-08-06 22:21    [W:0.088 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site