Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 30 Aug 2012 21:25:52 -0700 | Subject | Re: [REGRESSION] Xorg doesn't like 4e8b14526 "time: Improve sanity checking of timekeeping inputs" |
| |
On Thu, Aug 30, 2012 at 9:05 PM, Andreas Bombe <aeb@debian.org> wrote: > > With that somewhat easy test I bisected it down to 4e8b14526 "time: > Improve sanity checking of timekeeping inputs". The latest Linus git > (155e36d40) with a revert of the bisected commit does not show the > problem.
Ok, I guess we need to revert it. Although it might be interesting to add a WARN_ON_ONCE() for the case of timespec_valid() returning false, to just see exactly *where* that thing triggers. Could you do that? In fact, do it with separate WARN_ON_ONCE's for each of the reasons that function returns false, so that we also see which check it is that triggers. Ok?
Linus
| |