lkml.org 
[lkml]   [2012]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH tip/core/rcu 07/15] rcu: Fix obsolete rcu_initiate_boost() header comment
    On Thu, Aug 30, 2012 at 11:56:20AM -0700, Paul E. McKenney wrote:
    > From: "Paul E. McKenney" <paul.mckenney@linaro.org>
    >
    > Commit 1217ed1b (rcu: permit rcu_read_unlock() to be called while holding
    > runqueue locks) made rcu_initiate_boost() restore irq state when releasing
    > the rcu_node structure's ->lock, but failed to update the header comment
    > accordingly. This commit therefore brings the header comment up to date.
    >
    > Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
    > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

    Reviewed-by: Josh Triplett <josh@joshtriplett.org>

    > ---
    > kernel/rcutree_plugin.h | 6 +++---
    > 1 files changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
    > index c930a47..3ea60c9 100644
    > --- a/kernel/rcutree_plugin.h
    > +++ b/kernel/rcutree_plugin.h
    > @@ -1193,9 +1193,9 @@ static int rcu_boost_kthread(void *arg)
    > * kthread to start boosting them. If there is an expedited grace
    > * period in progress, it is always time to boost.
    > *
    > - * The caller must hold rnp->lock, which this function releases,
    > - * but irqs remain disabled. The ->boost_kthread_task is immortal,
    > - * so we don't need to worry about it going away.
    > + * The caller must hold rnp->lock, which this function releases.
    > + * The ->boost_kthread_task is immortal, so we don't need to worry
    > + * about it going away.
    > */
    > static void rcu_initiate_boost(struct rcu_node *rnp, unsigned long flags)
    > {
    > --
    > 1.7.8
    >


    \
     
     \ /
      Last update: 2012-08-31 20:41    [W:0.046 / U:0.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site