Messages in this thread | | | Date | Fri, 3 Aug 2012 15:23:39 -0700 | From | Tejun Heo <> | Subject | Re: [RFC v2 1/7] hashtable: introduce a small and naive hashtable |
| |
Hello,
On Sat, Aug 04, 2012 at 12:20:02AM +0200, Sasha Levin wrote: > On 08/03/2012 11:48 PM, Tejun Heo wrote: > > On Fri, Aug 03, 2012 at 11:41:34PM +0200, Sasha Levin wrote: > >> I forgot to comment on that one, sorry. > >> > >> If we put hash entries after struct hash_table we don't take the > >> bits field size into account, or did I miss something? > > > > So, if you do the following, > > > > struct { > > struct { > > int i; > > long ar[]; > > } B; > > long __ar_storage[32]; > > } A; > > struct A should have been an union, right?
I actually meant an enclosing struct. When you're defining a struct member, simply putting the storage after a struct with var array should be good enough. If that doesn't work, quite a few things in the kernel will break.
Thanks.
-- tejun
| |