Messages in this thread | | | From | "Pandita, Vikram" <> | Date | Fri, 3 Aug 2012 14:24:20 -0700 | Subject | Re: [PATCH v3] printk: add option to print cpu id |
| |
Aaro
On Fri, Aug 3, 2012 at 1:08 PM, Aaro Koskinen <aaro.koskinen@iki.fi> wrote: > Hi, > > On Fri, Aug 03, 2012 at 11:25:37AM -0700, Pandita, Vikram wrote: >> > And really: Wasting 1/3 of the 80 character line is too much. >> >> You _WASTE_ 4 chars only if you are interested in this info by >> enabling: CONFIG_PRINTK_CPUID > > I guess you waste 4 + 3 chars? You could optimize the length by checking > CONFIG_NR_CPUS?
Good point. Looks there is a variable 'nr_cpu_ids' that could be used as well.
If there is general consensus that the patch can help the arm community, and others in general, this optimization should be easy to implement - saving few chars space in each line of console output.
For now i will stick to this v3 version of path, unless you think otherwise.
> > A.
| |