lkml.org 
[lkml]   [2012]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/2] I2C: SIS964: Bus driver
Hi Amaury,

On Fri, 3 Aug 2012 17:35:43 +0200, Amaury Decrême wrote:
> This series of patches are a I2C bus driver for the SIS964.
>
>
> The SIS964 is nearly the same as SIS630 for the SMBUS :
> - Most of the SMBus registers (Status, Enable, Control,
> Host Control, etc.) are at the same adresses + 0x60
> - The register count is 21 instead of 20
>
> The SIS964 name is ambiguous as this chip isn't part of the SIS96X
> family and behaves differently.
>
> The datasheets have been used to develop the driver based on the
> exsiting driver for I2C SIS630 .

What is the rationale for not adding support for the new chip to
i2c-sis630 then? That would probably be a lot easier to review.

> Content of the patches:
> - 1/2 The driver itself
> - 2/2 Documentation, Kconfig, Makefile, Maintainers

This split makes little sense. Integration should come with the driver,
otherwise even build-testing is impossible.


--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-08-03 18:41    [W:0.086 / U:0.360 seconds]
©2003-2014 Jasper Spaans. Advertise on this site