Messages in this thread | | | Date | Fri, 03 Aug 2012 16:13:54 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH 4/9] KVM: define kvm_bad_pfn statically |
| |
Marcelo, Paul,
Thanks for your review!
On 08/03/2012 08:01 AM, Paul Mackerras wrote: > On Thu, Aug 02, 2012 at 10:15:27AM -0300, Marcelo Tosatti wrote: > >> Remind me what is the guarantee that -Exxx does not clash with >> a valid pfn number? > > A pfn number is an address >> PAGE_SHIFT, so it will have the top 12 > (at least) bits clear, whereas -Exxx will have the top bit set. >
Yes.
As this way is hard to understand and it will break huge memory support on PAE 32bit cpu, i have used a new way in the v2:
http://marc.info/?l=linux-kernel&m=134398012027025&w=2
Please review the new version.
| |