Messages in this thread | | | Date | Thu, 30 Aug 2012 03:35:33 +0200 | From | Pablo Neira Ayuso <> | Subject | Re: [PATCH 6/7] net/netfilter/nfnetlink_log.c: fix error return code |
| |
On Wed, Aug 29, 2012 at 06:49:17PM +0200, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Initialize return variable before exiting on an error path. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > ( > if@p1 (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret@p1 = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > > // </smpl>
And also applied, thanks Julia. I'll pass these to current -rc.
| |