lkml.org 
[lkml]   [2012]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/6] x86: Only direct map addresses that are marked as E820_RAM
    Date
    Currently direct mappings are created for [ 0 to max_low_pfn<<PAGE_SHIFT )
    and [ 4GB to max_pfn<<PAGE_SHIFT ), which may include regions that are not
    backed by actual DRAM. This is fine for holes under 4GB which are covered
    by fixed and variable range MTRRs to be UC. However, we run into trouble
    on higher memory addresses which cannot be covered by MTRRs.

    Our system with 1TB of RAM has an e820 that looks like this:

    BIOS-e820: [mem 0x0000000000000000-0x00000000000983ff] usable
    BIOS-e820: [mem 0x0000000000098400-0x000000000009ffff] reserved
    BIOS-e820: [mem 0x00000000000d0000-0x00000000000fffff] reserved
    BIOS-e820: [mem 0x0000000000100000-0x00000000c7ebffff] usable
    BIOS-e820: [mem 0x00000000c7ec0000-0x00000000c7ed7fff] ACPI data
    BIOS-e820: [mem 0x00000000c7ed8000-0x00000000c7ed9fff] ACPI NVS
    BIOS-e820: [mem 0x00000000c7eda000-0x00000000c7ffffff] reserved
    BIOS-e820: [mem 0x00000000fec00000-0x00000000fec0ffff] reserved
    BIOS-e820: [mem 0x00000000fee00000-0x00000000fee00fff] reserved
    BIOS-e820: [mem 0x00000000fff00000-0x00000000ffffffff] reserved
    BIOS-e820: [mem 0x0000000100000000-0x000000e037ffffff] usable
    BIOS-e820: [mem 0x000000e038000000-0x000000fcffffffff] reserved
    BIOS-e820: [mem 0x0000010000000000-0x0000011ffeffffff] usable

    and so direct mappings are created for huge memory hole between
    0x000000e038000000 to 0x0000010000000000. Even though the kernel never
    generates memory accesses in that region, since the page tables mark
    them incorrectly as being WB, our (AMD) processor ends up causing a MCE
    while doing some memory bookkeeping/optimizations around that area.

    This patch iterates through e820 and only direct maps ranges that are
    marked as E820_RAM, and keeps track of those pfn ranges. Depending on
    the alignment of E820 ranges, this may possibly result in using smaller
    size (i.e. 4K instead of 2M or 1G) page tables.

    Signed-off-by: Jacob Shin <jacob.shin@amd.com>
    ---
    arch/x86/include/asm/page_types.h | 9 ++++
    arch/x86/kernel/setup.c | 100 +++++++++++++++++++++++++++++++------
    arch/x86/mm/init.c | 2 +
    arch/x86/mm/init_64.c | 6 +--
    4 files changed, 99 insertions(+), 18 deletions(-)

    diff --git a/arch/x86/include/asm/page_types.h b/arch/x86/include/asm/page_types.h
    index e21fdd1..409047a 100644
    --- a/arch/x86/include/asm/page_types.h
    +++ b/arch/x86/include/asm/page_types.h
    @@ -3,6 +3,7 @@

    #include <linux/const.h>
    #include <linux/types.h>
    +#include <asm/e820.h>

    /* PAGE_SHIFT determines the page size */
    #define PAGE_SHIFT 12
    @@ -40,12 +41,20 @@
    #endif /* CONFIG_X86_64 */

    #ifndef __ASSEMBLY__
    +#include <linux/range.h>

    extern int devmem_is_allowed(unsigned long pagenr);

    extern unsigned long max_low_pfn_mapped;
    extern unsigned long max_pfn_mapped;

    +extern struct range pfn_mapped[E820_X_MAX];
    +extern int nr_pfn_mapped;
    +
    +extern void add_pfn_range_mapped(unsigned long start_pfn, unsigned long end_pfn);
    +extern bool pfn_range_is_mapped(unsigned long start_pfn, unsigned long end_pfn);
    +extern bool pfn_is_mapped(unsigned long pfn);
    +
    static inline phys_addr_t get_max_mapped(void)
    {
    return (phys_addr_t)max_pfn_mapped << PAGE_SHIFT;
    diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
    index d6e8c03..a2e392e 100644
    --- a/arch/x86/kernel/setup.c
    +++ b/arch/x86/kernel/setup.c
    @@ -115,13 +115,47 @@
    #include <asm/prom.h>

    /*
    - * end_pfn only includes RAM, while max_pfn_mapped includes all e820 entries.
    - * The direct mapping extends to max_pfn_mapped, so that we can directly access
    - * apertures, ACPI and other tables without having to play with fixmaps.
    + * max_low_pfn_mapped: highest direct mapped pfn under 4GB
    + * max_pfn_mapped: highest direct mapped pfn over 4GB
    + *
    + * The direct mapping only covers E820_RAM regions, so the ranges and gaps are
    + * represented by pfn_mapped
    */
    unsigned long max_low_pfn_mapped;
    unsigned long max_pfn_mapped;

    +struct range pfn_mapped[E820_X_MAX];
    +int nr_pfn_mapped;
    +
    +void add_pfn_range_mapped(unsigned long start_pfn, unsigned long end_pfn)
    +{
    + nr_pfn_mapped = add_range_with_merge(pfn_mapped, E820_X_MAX,
    + nr_pfn_mapped, start_pfn, end_pfn);
    + nr_pfn_mapped = clean_sort_range(pfn_mapped, E820_X_MAX);
    +
    + max_pfn_mapped = max(max_pfn_mapped, end_pfn);
    +
    + if (end_pfn <= (1UL << (32 - PAGE_SHIFT)))
    + max_low_pfn_mapped = max(max_low_pfn_mapped, end_pfn);
    +}
    +
    +bool pfn_range_is_mapped(unsigned long start_pfn, unsigned long end_pfn)
    +{
    + int i;
    +
    + for (i = 0; i < nr_pfn_mapped; i++)
    + if ((start_pfn >= pfn_mapped[i].start) &&
    + (end_pfn <= pfn_mapped[i].end))
    + return true;
    +
    + return false;
    +}
    +
    +bool pfn_is_mapped(unsigned long pfn)
    +{
    + return pfn_range_is_mapped(pfn, pfn + 1);
    +}
    +
    #ifdef CONFIG_DMI
    RESERVE_BRK(dmi_alloc, 65536);
    #endif
    @@ -296,6 +330,54 @@ static void __init cleanup_highmap(void)
    }
    #endif

    +/*
    + * Iterate through E820 memory map and create direct mappings for only E820_RAM
    + * regions. We cannot simply create direct mappings for all pfns from
    + * [0 to max_low_pfn) and [4GB to max_pfn) because of possible memory holes in
    + * high addresses that cannot be marked as UC by fixed/variable range MTRRs.
    + * Depending on the alignment of E820 ranges, this may possibly result in using
    + * smaller size (i.e. 4K instead of 2M or 1G) page tables.
    + */
    +static void __init init_direct_mapping(void)
    +{
    + int i;
    +
    + /* the ISA range is always mapped regardless of memory holes */
    + init_memory_mapping(0, ISA_END_ADDRESS);
    +
    + for (i = 0; i < e820.nr_map; i++) {
    + struct e820entry *ei = &e820.map[i];
    + u64 start = ei->addr;
    + u64 end = ei->addr + ei->size;
    +
    + /* we only map E820_RAM */
    + if (ei->type != E820_RAM)
    + continue;
    +
    + if (end <= ISA_END_ADDRESS)
    + continue;
    +
    + if (start < ISA_END_ADDRESS)
    + start = ISA_END_ADDRESS;
    +#ifdef CONFIG_X86_32
    + /* on 32 bit, we only map up to max_low_pfn */
    + if ((start >> PAGE_SHIFT) >= max_low_pfn)
    + continue;
    +
    + if ((end >> PAGE_SHIFT) > max_low_pfn)
    + end = max_low_pfn << PAGE_SHIFT;
    +#endif
    + init_memory_mapping(start, end);
    + }
    +
    +#ifdef CONFIG_X86_64
    + if (max_pfn > max_low_pfn) {
    + /* can we preseve max_low_pfn ?*/
    + max_low_pfn = max_pfn;
    + }
    +#endif
    +}
    +
    static void __init reserve_brk(void)
    {
    if (_brk_end > _brk_start)
    @@ -914,18 +996,8 @@ void __init setup_arch(char **cmdline_p)
    init_gbpages();
    probe_page_size_mask();

    - /* max_pfn_mapped is updated here */
    - max_low_pfn_mapped = init_memory_mapping(0, max_low_pfn<<PAGE_SHIFT);
    - max_pfn_mapped = max_low_pfn_mapped;
    + init_direct_mapping();

    -#ifdef CONFIG_X86_64
    - if (max_pfn > max_low_pfn) {
    - max_pfn_mapped = init_memory_mapping(1UL<<32,
    - max_pfn<<PAGE_SHIFT);
    - /* can we preseve max_low_pfn ?*/
    - max_low_pfn = max_pfn;
    - }
    -#endif
    memblock.current_limit = get_max_mapped();
    dma_contiguous_reserve(0);

    diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
    index 916b15b..4ec6968 100644
    --- a/arch/x86/mm/init.c
    +++ b/arch/x86/mm/init.c
    @@ -317,6 +317,8 @@ unsigned long __init_refok init_memory_mapping(unsigned long start,
    if (!after_bootmem)
    early_memtest(start, end);

    + add_pfn_range_mapped(start >> PAGE_SHIFT, ret >> PAGE_SHIFT);
    +
    return ret >> PAGE_SHIFT;
    }

    diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
    index 2b6b4a3..ab558eb 100644
    --- a/arch/x86/mm/init_64.c
    +++ b/arch/x86/mm/init_64.c
    @@ -657,13 +657,11 @@ int arch_add_memory(int nid, u64 start, u64 size)
    {
    struct pglist_data *pgdat = NODE_DATA(nid);
    struct zone *zone = pgdat->node_zones + ZONE_NORMAL;
    - unsigned long last_mapped_pfn, start_pfn = start >> PAGE_SHIFT;
    + unsigned long start_pfn = start >> PAGE_SHIFT;
    unsigned long nr_pages = size >> PAGE_SHIFT;
    int ret;

    - last_mapped_pfn = init_memory_mapping(start, start + size);
    - if (last_mapped_pfn > max_pfn_mapped)
    - max_pfn_mapped = last_mapped_pfn;
    + init_memory_mapping(start, start + size);

    ret = __add_pages(nid, zone, start_pfn, nr_pages);
    WARN_ON_ONCE(ret);
    --
    1.7.9.5



    \
     
     \ /
      Last update: 2012-08-29 21:41    [W:0.038 / U:91.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site