| Date | Sun, 26 Aug 2012 20:10:10 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH 06/19] x86, msi: Use IRQ remapping specific setup_msi_irqs routine |
| |
On Mon, Aug 20, 2012 at 03:55:52PM +0200, Joerg Roedel wrote: > diff --git a/drivers/iommu/irq_remapping.c b/drivers/iommu/irq_remapping.c > index f439151..984104b 100644 > --- a/drivers/iommu/irq_remapping.c > +++ b/drivers/iommu/irq_remapping.c > @@ -181,7 +232,7 @@ void compose_remapped_msi_msg(struct pci_dev *pdev, > remap_ops->compose_msi_msg(pdev, irq, dest, msg, hpet_id); > } > > -int msi_alloc_remapped_irq(struct pci_dev *pdev, int irq, int nvec) > +static int msi_alloc_remapped_irq(struct pci_dev *pdev, int irq, int nvec) > { > if (!remap_ops || !remap_ops->msi_alloc_irq) > return -ENODEV; > @@ -189,8 +240,8 @@ int msi_alloc_remapped_irq(struct pci_dev *pdev, int irq, int nvec) > return remap_ops->msi_alloc_irq(pdev, irq, nvec); > } > > -int msi_setup_remapped_irq(struct pci_dev *pdev, unsigned int irq, > - int index, int sub_handle) > +static int msi_setup_remapped_irq(struct pci_dev *pdev, unsigned int irq, > + int index, int sub_handle) > { > if (!remap_ops || !remap_ops->msi_setup_irq) > return -ENODEV;
Both functions, that is msi_alloc_remapped_irq() and msi_setup_remapped_irq() and are now called only from irq_remapping_setup_msi_irqs() which can only be called once remap_ops are set.
Sebastian
|