lkml.org 
[lkml]   [2012]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2/2] PCI: Remove the obsolete no_pci_devices() check
    From 9f2f3bbdf65f669e091c72b9648a4a0394ce28f5 Mon Sep 17 00:00:00 2001
    From: Feng Tang <feng.tang@intel.com>
    Date: Thu, 23 Aug 2012 14:55:48 +0800
    Subject: [PATCH 2/2] PCI: Remove the obsolete no_pci_devices() check

    In function pci_get_subsys() there is a check:

    /*
    * pci_find_subsys() can be called on the ide_setup() path,
    * super-early in boot. But the down_read() will enable local
    * interrupts, which can cause some machines to crash. So here we
    * detect and flag that situation and bail out early.
    */
    if (unlikely(no_pci_devices()))
    return NULL;

    But there is no ide_setup() now, and no down_read() either, which
    makes the check absolete. So remove it.

    Signed-off-by: Feng Tang <feng.tang@intel.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/pci/search.c | 9 ---------
    1 files changed, 0 insertions(+), 9 deletions(-)

    diff --git a/drivers/pci/search.c b/drivers/pci/search.c
    index 78a08b1..e6e604f 100644
    --- a/drivers/pci/search.c
    +++ b/drivers/pci/search.c
    @@ -247,15 +247,6 @@ struct pci_dev *pci_get_subsys(unsigned int vendor, unsigned int device,
    {
    struct pci_device_id id;

    - /*
    - * pci_find_subsys() can be called on the ide_setup() path,
    - * super-early in boot. But the down_read() will enable local
    - * interrupts, which can cause some machines to crash. So here we
    - * detect and flag that situation and bail out early.
    - */
    - if (unlikely(no_pci_devices()))
    - return NULL;
    -
    id.vendor = vendor;
    id.device = device;
    id.subvendor = ss_vendor;
    --
    1.7.1

    \
     
     \ /
      Last update: 2012-08-23 10:41    [W:0.028 / U:31.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site