lkml.org 
[lkml]   [2012]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/5] drivers/video/msm/mddi_client_nt35399.c: use devm_ functions
    On 08/03/2012 03:40 PM, Damien Cassou wrote:
    > From: Damien Cassou <damien.cassou@lifl.fr>
    >
    > The various devm_ functions allocate memory that is released when a driver
    > detaches. This patch replaces the use of kzalloc by devm_kzalloc.
    >
    > Additionally, this patch fixes a memory leak: some memory was allocated for
    > 'panel' but not released when the subsequent call to setup_vsync fails.
    >
    > Signed-off-by: Damien Cassou <damien.cassou@lifl.fr>

    Applied.


    Thanks,

    Florian Tobias Schandinat

    >
    > ---
    > drivers/video/msm/mddi_client_nt35399.c | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/video/msm/mddi_client_nt35399.c b/drivers/video/msm/mddi_client_nt35399.c
    > index 7fcd67e..66b314e 100644
    > --- a/drivers/video/msm/mddi_client_nt35399.c
    > +++ b/drivers/video/msm/mddi_client_nt35399.c
    > @@ -189,8 +189,9 @@ static int mddi_nt35399_probe(struct platform_device *pdev)
    >
    > int ret;
    >
    > - struct panel_info *panel = kzalloc(sizeof(struct panel_info),
    > - GFP_KERNEL);
    > + struct panel_info *panel = devm_kzalloc(&pdev->dev,
    > + sizeof(struct panel_info),
    > + GFP_KERNEL);
    >
    > printk(KERN_DEBUG "%s: enter.\n", __func__);
    >
    > @@ -233,7 +234,6 @@ static int mddi_nt35399_remove(struct platform_device *pdev)
    > struct panel_info *panel = platform_get_drvdata(pdev);
    >
    > setup_vsync(panel, 0);
    > - kfree(panel);
    > return 0;
    > }
    >



    \
     
     \ /
      Last update: 2012-08-24 00:01    [W:0.033 / U:36.732 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site