lkml.org 
[lkml]   [2012]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register
    On Wed, Aug 22, 2012 at 11:21:03PM -0600, Stephen Warren wrote:
    > On 08/22/2012 01:18 AM, Dong Aisheng wrote:
    > > Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
    >
    > > diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop-regulator.c
    >
    > > @@ -109,7 +110,11 @@ static int __devinit anatop_regulator_probe(struct platform_device *pdev)
    > > rdesc->ops = &anatop_rops;
    > > rdesc->type = REGULATOR_VOLTAGE;
    > > rdesc->owner = THIS_MODULE;
    > > - sreg->mfd = anatopmfd;
    > > +
    > > + sreg->anatop = of_parse_phandle(np, "fsl,anatop", 0);
    > > + if (!sreg->anatop)
    > > + return -ENODEV;
    >
    > In fact, that imx_syscon_lookup function I proposed could even do the
    > of_parse_phandle() internally, so perhaps:
    >
    > foo->syscon_dev = imx_syscon_lookup(np, "fsl,anatop", 0);
    > if (IS_ERR(foo->syscon_dev))
    > return PTR_ERR(foo->syscon_dev);
    >
    > with imx_syscon_lookup() internally knowing when to return EPROBE_DEFER
    > rather than any other permanent error code (e.g. for missing property,
    > bad phandle, etc.)
    In some case that we access register in machine code, we don't have any
    phandler. The node is got by find compatible or by path.

    Thanks
    Richard



    \
     
     \ /
      Last update: 2012-08-23 09:01    [W:0.041 / U:0.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site