Messages in this thread | | | Date | Tue, 21 Aug 2012 20:04:41 +0400 | From | Stanislav Kinsbursky <> | Subject | Re: [PATCH] tun: don't zeroize sock->file on detach |
| |
10.08.2012 03:16, David Miller пишет: > From: Stanislav Kinsbursky <skinsbursky@parallels.com> > Date: Thu, 09 Aug 2012 16:50:40 +0400 > >> This is a fix for bug, introduced in 3.4 kernel by commit >> 1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d, which, among other things, replaced >> simple sock_put() by sk_release_kernel(). Below is sequence, which leads to >> oops for non-persistent devices: >> >> tun_chr_close() >> tun_detach() <== tun->socket.file = NULL >> tun_free_netdev() >> sk_release_sock() >> sock_release(sock->file == NULL) >> iput(SOCK_INODE(sock)) <== dereference on NULL pointer >> >> This patch just removes zeroing of socket's file from __tun_detach(). >> sock_release() will do this. >> >> Cc: stable@vger.kernel.org >> Reported-by: Ruan Zhijie <ruanzhijie@hotmail.com> >> Tested-by: Ruan Zhijie <ruanzhijie@hotmail.com> >> Acked-by: Al Viro <viro@ZenIV.linux.org.uk> >> Acked-by: Eric Dumazet <edumazet@google.com> >> Acked-by: Yuchung Cheng <ycheng@google.com> >> Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com> > > Applied, thanks. >
Hi, David. I found out, that this commit: b09e786bd1dd66418b69348cb110f3a64764626a was previous attempt to fix the problem. I believe this commit have to be dropped.
-- Best regards, Stanislav Kinsbursky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |