Messages in this thread | | | Date | Tue, 21 Aug 2012 10:50:51 +0100 | From | Catalin Marinas <> | Subject | Re: [PATCH v2 08/31] arm64: CPU support |
| |
On Mon, Aug 20, 2012 at 09:47:07PM +0100, Arnd Bergmann wrote: > On Monday 20 August 2012, Catalin Marinas wrote: > > > > --- /dev/null > > > > +++ b/arch/arm64/mm/proc-syms.c > > ... > > > > +EXPORT_SYMBOL(__cpuc_flush_kern_all); > > > > +EXPORT_SYMBOL(__cpuc_flush_user_all); > > > > +EXPORT_SYMBOL(__cpuc_flush_user_range); > > > > +EXPORT_SYMBOL(__cpuc_coherent_kern_range); > > > > +EXPORT_SYMBOL(__cpuc_flush_dcache_area); > > > > > > See comment on other email about putting function pointers in a struct > > > instead. > > > > There is no need to support multiple CPU architectures with different > > implementations, so allowing these functions to be called without > > indirection is better. > > What is the __cpuc prefix about then? Could you just drop it?
It can be dropped indeed.
-- Catalin
| |