lkml.org 
[lkml]   [2012]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/21] userns: Use kgids for sysctl_ping_group_range
    On Mon, Aug 13, 2012 at 13:18 -0700, Eric W. Biederman wrote:
    > From: "Eric W. Biederman" <ebiederm@xmission.com>
    >
    > - Store sysctl_ping_group_range as a paire of kgid_t values
    > instead of a pair of gid_t values.
    > - Move the kgid conversion work from ping_init_sock into ipv4_ping_group_range
    > - For invalid cases reset to the default disabled state.
    >
    > With the kgid_t conversion made part of the original value sanitation
    > from userspace understand how the code will react becomes clearer
    > and it becomes possible to set the sysctl ping group range from
    > something other than the initial user namespace.
    >
    > Cc: Vasiliy Kulikov <segoon@openwall.com>
    > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>

    Looks good.

    Acked-by: Vasiliy Kulikov <segoon@openwall.com>

    Thanks,

    --
    Vasiliy Kulikov
    http://www.openwall.com - bringing security into open computing environments


    \
     
     \ /
      Last update: 2012-08-20 20:41    [W:0.031 / U:7.316 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site