Messages in this thread | | | Date | Mon, 20 Aug 2012 02:48:08 -0700 (PDT) | Subject | Re: [PATCH] caif: Do not dereference NULL in chnl_recv_cb() | From | David Miller <> |
| |
From: Sjur BRENDELAND <sjur.brandeland@stericsson.com> Date: Mon, 20 Aug 2012 08:33:35 +0200
>> In net/caif/chnl_net.c::chnl_recv_cb() we call skb_header_pointer() >> which may return NULL, but we do not check for a NULL pointer before >> dereferencing it. >> This patch adds such a NULL check and properly free's allocated memory >> and return an error (-EINVAL) on failure - much better than crashing.. >> >> Signed-off-by: Jesper Juhl <jj@chaosbits.net> > > Thank you for fixing this, the patch looks good to me. > Acked-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |