lkml.org 
[lkml]   [2012]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 23/46] ext4: avoid kmemcheck complaint from reading uninitialized memory
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.5-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit 7e731bc9a12339f344cddf82166b82633d99dd86 upstream.

    Commit 03179fe923 introduced a kmemcheck complaint in
    ext4_da_get_block_prep() because we save and restore
    ei->i_da_metadata_calc_last_lblock even though it is left
    uninitialized in the case where i_da_metadata_calc_len is zero.

    This doesn't hurt anything, but silencing the kmemcheck complaint
    makes it easier for people to find real bugs.

    Addresses https://bugzilla.kernel.org/show_bug.cgi?id=45631
    (which is marked as a regression).

    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/super.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/ext4/super.c
    +++ b/fs/ext4/super.c
    @@ -976,6 +976,7 @@ static struct inode *ext4_alloc_inode(st
    ei->i_reserved_meta_blocks = 0;
    ei->i_allocated_meta_blocks = 0;
    ei->i_da_metadata_calc_len = 0;
    + ei->i_da_metadata_calc_last_lblock = 0;
    spin_lock_init(&(ei->i_block_reservation_lock));
    #ifdef CONFIG_QUOTA
    ei->i_reserved_quota = 0;



    \
     
     \ /
      Last update: 2012-08-20 07:01    [W:0.025 / U:29.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site