Messages in this thread | | | Date | Thu, 2 Aug 2012 18:19:17 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH v2] sparc64: do not clobber personality flags in sys_sparc64_personality() |
| |
On Thu, Aug 02, 2012 at 09:12:46AM +0200, Jiri Kosina wrote: > >From 4f000eda5917ceecb03767962026cc6a390b8216 Mon Sep 17 00:00:00 2001 > From: Jiri Kosina <jkosina@suse.cz> > Date: Wed, 1 Aug 2012 21:10:51 +0200 > Subject: [PATCH 4/4] sparc64: do not clobber personality flags in sys_sparc64_personality() > > There are multiple errors in how sys_sparc64_personality() handles > personality flags stored in top three bytes. > > - directly comparing current->personality against PER_LINUX32 doesn't work > in cases when any of the personality flags stored in the top three bytes > are used. > - directly forcefully setting personality to PER_LINUX32 or PER_LINUX > discards any flags stored in the top three bytes > > Fix the first one by properly using personality() macro to compare only > PER_MASK bytes. > Fix the second one by setting only the bits that should be set, instead of > overwriting the whole value.
Hi Jiri.
Can you have a quick look at this too: arch/sparc/include/asm/elf_32.h:#define SET_PERSONALITY(ex) set_personality(PER_LINUX)
From your other comments it looks wrong. But I have not digged into this.
Thanks, Sam
| |