lkml.org 
[lkml]   [2012]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] uprobes: Ignore unsupported instructions in uprobe_mmap
    Forgot to mention...

    On 08/02, Srikar Dronamraju wrote:
    >
    > While at it, add a missing put_uprobe() in the path where uprobe_mmap()
    > races with uprobe_unregister().
    > ...
    > @@ -1051,8 +1051,10 @@ int uprobe_mmap(struct vm_area_struct *vma)
    > if (ret == -EEXIST) {
    > ret = 0;
    >
    > - if (!is_swbp_at_addr(vma->vm_mm, vaddr))
    > + if (!is_swbp_at_addr(vma->vm_mm, vaddr)) {
    > + put_uprobe(uprobe);
    > continue;
    > + }

    Yes, this part looks correct.

    In fact, I think this is not really correct anyway (wrt counter)
    but we are going to kill it.

    Oleg.



    \
     
     \ /
      Last update: 2012-08-02 17:01    [W:0.051 / U:30.960 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site